gremlin_python: generate/build/deps before tests#344
Merged
asfgit merged 1 commit intoapache:TINKERPOP-1278from Jun 22, 2016
Merged
gremlin_python: generate/build/deps before tests#344asfgit merged 1 commit intoapache:TINKERPOP-1278from
asfgit merged 1 commit intoapache:TINKERPOP-1278from
Conversation
Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.
252e358 to
df0896c
Compare
Author
|
I think this should fix the CI test failures. On the subject of the python dependencies (aenum and requests), should they be bundled in the jar? aenum has a 3-clause BSD license, and requests uses the ASL. |
Author
|
Also, the generated Please advise. |
Contributor
|
Can you add the license boilerplate? BTW: Just pulled your patch and building locally now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.