Skip to content

gremlin_python: generate/build/deps before tests#344

Merged
asfgit merged 1 commit intoapache:TINKERPOP-1278from
leifurhauks:python_test_fix
Jun 22, 2016
Merged

gremlin_python: generate/build/deps before tests#344
asfgit merged 1 commit intoapache:TINKERPOP-1278from
leifurhauks:python_test_fix

Conversation

@leifurhauks
Copy link

Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.

Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.
@leifurhauks
Copy link
Author

I think this should fix the CI test failures.

On the subject of the python dependencies (aenum and requests), should they be bundled in the jar? aenum has a 3-clause BSD license, and requests uses the ASL.

@leifurhauks
Copy link
Author

Also, the generated __version__.py file fails the rat check. I think it needs to be either
a) generated with the license boilerplate
b) excluded from the rat check, or
c) included in the clean configuration.

Please advise.

@okram
Copy link
Contributor

okram commented Jun 22, 2016

Can you add the license boilerplate?

BTW: Just pulled your patch and building locally now.

@asfgit asfgit merged commit df0896c into apache:TINKERPOP-1278 Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants