Skip to content

Conversation

@spmallette
Copy link
Contributor

Just a documentation addition. I learned that it's not so good to CTR these as there is sometimes good feedback on Gremlin code that should be incorporated and a PR is the best way to go about gathering that feedback.

VOTE +1

@spmallette
Copy link
Contributor Author

Please ignore the failing test:

IdentityRemovalStrategyTest$PerformanceTest>TraversalStrategyPerformanceTest.shouldBeFaster:107 null

that's an issue raised elsewhere: https://issues.apache.org/jira/browse/TINKERPOP-1390

@twilmes
Copy link
Contributor

twilmes commented Aug 4, 2016

I might be missing something silly here, but It looks like you need to commit traversal-induced-values.asciidoc. I'm only seeing the updates to the changelog and index on this branch.

@spmallette
Copy link
Contributor Author

Sorry - forgot to add the file @twilmes - fixed up the commit and force pushed.

@twilmes
Copy link
Contributor

twilmes commented Aug 4, 2016

Looks good, nice choice for a recipe.

VOTE: +1

@okram
Copy link
Contributor

okram commented Aug 4, 2016

VOTE +1.

This got me to thinking that we really need to start to extend other steps (beyond the Mutating) to support traversal parameterization.

age is greater than the "marko" age. If this is successful, then the `filter` step from the previous line will succeed
and allow the "friend" vertex to pass through.

This traversal could also be written declaratively with `match` step as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any discussion of the possible performance differences between the 2 approaches? Or is that mostly a system-specific discussion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about going into more detail there, but opted not to. I kinda thought that if we wanted that sort of content that it didn't belong in a recipe but in reference docs. It seemed a little out of scope of the recipe.

@asfgit asfgit merged commit ee50a6f into master Aug 5, 2016
@asfgit asfgit deleted the TINKERPOP-1396 branch September 15, 2016 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants