TINKERPOP-1467 Corrected a number of problems in close() operations for the driver [tp31]#441
Merged
TINKERPOP-1467 Corrected a number of problems in close() operations for the driver [tp31]#441
Conversation
asfgit
force-pushed
the
TINKERPOP-1467
branch
from
c3acce6 to
91769ea
Compare
dkuppitz
requested changes
Sep 29, 2016
| sessionlessThree.close(); | ||
| cluster.close(); | ||
|
|
||
| try { |
Contributor
There was a problem hiding this comment.
It is not verified, that exceptions are actually thrown. Should be more like:
try {
sessionXyz.submit("1+1").all().get();
assertTrue(false);
} catch (Exception ex) {
....
| ^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| There were a few problems noted around the `close()` of `Cluster` and `Client` instances, including issues that | ||
| presented as system hangs. These issues have been resolved, however, it is worth nothing that an unchecked exception |
Contributor
There was a problem hiding this comment.
worth nothing => worth noting
asfgit
force-pushed
the
TINKERPOP-1467
branch
from
91769ea to
0c87171
Compare
Contributor
|
As said in a private chat, integration tests were stuck when I ran them first. However, the second attempt succeeded. More investigation is apparently needed, but for this PR: VOTE: +1 |
asfgit
force-pushed
the
TINKERPOP-1467
branch
from
0c87171 to
90c0f3b
Compare
This was more of a commit than I wanted for tp31, but close() was really messed up. Fixed a number of race conditions and other logic that would allow the driver to hang on close. Also made it so that the Cluster makes an attempt to clean up any Client instances that it spawns.
asfgit
force-pushed
the
TINKERPOP-1467
branch
from
90c0f3b to
6d14adb
Compare
Contributor
Author
|
I ran the docker build multiple times today following the report of stuck integration tests. I never ran into the problem, but the adjustments I forced pushed prior to those tests hopefully fixed it. |
Contributor
|
FYI: 3x BUILD SUCCESS in a row. My vote still holds true. |
Contributor
|
VOTE +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1467
This was more of a commit than I wanted for
tp31, butclose()was really messed up. Fixed a number of race conditions and other logic that would allow the driver to hang on close. Also made it so that theClustermakes an attempt to clean up anyClientinstances that it spawns.Tested with
mvn clean installand endlessly withmvn verify -pl gremlin-server -DskipIntegrationTests=false(basically ran it for a whole day over and over again).VOTE +1