TINKERPOP-919 Added supportsDuplicateMultiProperties()#463
Merged
Conversation
Contributor
|
I was a confused for a bit on the method name. Seems (and this is just me) that a better name would be: To me this means same key, duplicate values. The problem with "identical" is that there is no such thing as identical as properties can have meta-properties and be different. Thus, its a key/value identity, not a key/value/properties/id identity. Dunno...whateves. |
Contributor
Author
|
i played with a lot of different words. "duplicate" was one. i don't mind changing it if you like that better. |
spmallette
changed the title
Contributor
Author
|
ok - renamed to use "duplicate" and rebased on tp32 |
Contributor
|
VOTE +1 |
That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key.
Contributor
|
VOTE: +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-919
That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key. Not sure why this wasn't implemented long ago. It was relatively straightforward to put in place. I did take a look at the test suite for existing tests that might have needed this feature included, but I didn't see any.
mvn clean install -DincludeNeo4jis all goodVOTE +1