TINKERPOP-1292: TinkerGraphComputer VertexProgramInterceptors #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn g.V().count() and g.E().count() into direct calls to the .size() of the underlying TinkerGraph.vertices/edges Maps. Removed the OptIn strategy suites in both TinkerGraph and Neo4jGraph -- this should have been done when these suites were removed long ago.
Contributor
|
VOTE: +1 |
…untGlobalStep patterns. Added more test cases to verify complex traversals.
spmallette
reviewed
Nov 3, 2016
| @Graph.OptIn(Graph.OptIn.SUITE_GROOVY_ENVIRONMENT_INTEGRATE) | ||
| @Graph.OptIn(Graph.OptIn.SUITE_GROOVY_ENVIRONMENT_PERFORMANCE) | ||
| @Graph.OptIn("org.apache.tinkerpop.gremlin.neo4j.NativeNeo4jSuite") | ||
| @Graph.OptIn("org.apache.tinkerpop.gremlin.neo4j.process.traversal.strategy.Neo4jStrategySuite") |
Contributor
There was a problem hiding this comment.
Out of curiosity, when did we drop these? Was it a long time ago?
Contributor
Author
There was a problem hiding this comment.
Yes. It is not the model we use for TraversalStrategy testing. I converted both Neo4j and TinkerGraph's strategy tests to the model we use in core/.
Contributor
|
All tests pass with VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1292
Added
TinkerGraphCountStrategywhich will translateg.V().count()andg.E().count()into direct calls to the underlyingTinkerGraph.vertices/edgeshash maps (.size()). Thus, no need to iterate out the vertices/edges and then count the iteration. O(1) time for count.--- we can extend on this line of reasoning in this branch if people have other ideas for shortcuts.
VOTE +1.