TINKERPOP-1714 GremlinExecutor checks for timeout from time script submitted#658
Merged
TINKERPOP-1714 GremlinExecutor checks for timeout from time script submitted#658
Conversation
…bmitted Prior to this change timeouts were considered from the time the script started evaluation which probably isn't in line with user expectations but also made it hard to clear the job queue on an overloaded server.
Contributor
|
VOTE: +1 |
Contributor
|
VOTE +1 |
Contributor
Author
|
This is merged but hasn't auto-closed yet - seems like the mirror/events are behind. Will keep an eye on it to see that it does indeed close itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1714
Prior to this change timeouts were considered from the time the script started evaluation which probably isn't in line with user expectations but also made it hard to clear the job queue on an overloaded server. This change also has the benefit of simplifying the code as well as reducing the number of jobs submitted to the various thread pools.
All tests pass with
docker/build.sh -t -n -iVOTE +1