TINKERPOP-1743: LambdaRestrictionStrategy does not catch lambdas passed to sack()

[okram]

https://issues.apache.org/jira/browse/TINKERPOP-1743

Fixed a lambda-leak in SackValueStep where BiFunction must be tested for true lambda status.

[okram]

gremlin> g = TinkerFactory.createModern().traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g = g.withStrategies(LambdaRestrictionStrategy.instance())
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g.withSack(0).V().limit(1).sack{ v,s -> System.exit(1) }
The provided step contains a lambda bi-function: SackValueStep(lambda)
Type ':help' or ':h' for help.
Display stack trace? [yN]
gremlin>

[okram]

VOTE +1

[spmallette]

I rebased this on tp32 and force pushed to get rid of that extra "fix" commit for bigdecimal. @okram you should:

git fetch
git branch -D TINKERPOP-1743
git checkout TINKERPOP-1743

before you merge this to release branches.

VOTE +1

[dkuppitz]

VOTE: +1