Skip to content

TINKERPOP-1760: OLAP compilation failing around ConnectiveStrategy#700

Merged
asfgit merged 2 commits intotp32from
TINKERPOP-1760
Aug 29, 2017
Merged

TINKERPOP-1760: OLAP compilation failing around ConnectiveStrategy#700
asfgit merged 2 commits intotp32from
TINKERPOP-1760

Conversation

@okram
Copy link
Copy Markdown
Contributor

@okram okram commented Aug 28, 2017

https://issues.apache.org/jira/browse/TINKERPOP-1760

The more general problem was in ComputerVerificationStrategy. The problem was the nested traversals were being analyzed prior to full strategy compilation. The solution actually simplified the code a bit.

gremlin> g = TinkerFactory.createModern().traversal().withComputer()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
gremlin> g.V().where(out("created").and().out("knows")).values("name")
==>marko

VOTE +1

okram added 2 commits August 28, 2017 10:58
…tionStrategy. Given the outside-in nature of Gremlin compilation, we were analyzing child traversals that were, in fact, not compiled yet. We now check for local star graph issues on a per traversal level. I can't believe we didn't run into other problems before this.
@dkuppitz
Copy link
Copy Markdown
Contributor

Any reason why this shouldn't go into tp32/?

@okram okram changed the base branch from master to tp32 August 28, 2017 19:38
@okram
Copy link
Copy Markdown
Contributor Author

okram commented Aug 28, 2017

No. I just spaced on selecting tp32/ and left it defaulted at master/. Fixed.

@dkuppitz
Copy link
Copy Markdown
Contributor

docker/build.sh -t -i succeeded.

VOTE: +1

@okram
Copy link
Copy Markdown
Contributor Author

okram commented Aug 28, 2017

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:21 h
[INFO] Finished at: 2017-08-28T16:04:55-06:00
[INFO] Final Memory: 162M/1646M
[INFO] ------------------------------------------------------------------------

@spmallette
Copy link
Copy Markdown
Contributor

All tests pass with docker/build.sh -t -n -i

VOTE +1

@asfgit asfgit merged commit eb1be4d into tp32 Aug 29, 2017
@asfgit asfgit deleted the TINKERPOP-1760 branch January 2, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants