Skip to content

TINKERPOP-1887 Allow to use bindings in predicates#797

Closed
eonpatapon wants to merge 1 commit intoapache:masterfrom
eonpatapon:TINKERPOP-1887
Closed

TINKERPOP-1887 Allow to use bindings in predicates#797
eonpatapon wants to merge 1 commit intoapache:masterfrom
eonpatapon:TINKERPOP-1887

Conversation

@eonpatapon
Copy link
Copy Markdown

Currently the python GLV does not allow to have bindings in predicates,
eg:

g.V().has('foo', lt(('bar', 10)))
g.V().has('foo', inside(('a', 10), ('b', 20)))

This patch fixes this

Currently the python GLV does not allow to have bindings in predicates,
eg:

    g.V().has('foo', lt(('bar', 10)))
    g.V().has('foo', inside(('a', 10), ('b', 20)))

This patch fixes this
@davebshow
Copy link
Copy Markdown
Contributor

This needs a test to demonstrate that it works. I haven't run the code yet, but what happens to the key value of the binding? Does this generate GraphSON with bindings, or just the values of the bindings?

@eonpatapon
Copy link
Copy Markdown
Author

Yes, can you point me to the test suite ? I wasn't able to find it in the repo

@davebshow
Copy link
Copy Markdown
Contributor

@eonpatapon
Copy link
Copy Markdown
Author

After playing with the code and tests I'm realizing this does not work at all :)

Closing for now.

@eonpatapon eonpatapon closed this Feb 13, 2018
@davebshow
Copy link
Copy Markdown
Contributor

There is a bit of a learning curve working with the Gremlin-Python source. Do you plan on giving this another try? If so, I will help you review. If not, let me know and I can give it a go.

@eonpatapon
Copy link
Copy Markdown
Author

eonpatapon commented Feb 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants