TINKERPOP-1365 Refactored use of Random in tests#881
Merged
Conversation
dkuppitz
requested changes
Jun 25, 2018
| static { | ||
| final long seed = Long.parseLong(System.getProperty("testSeed", String.valueOf(System.currentTimeMillis()))); | ||
| logger.info("*** THE RANDOM TEST SEED IS {} ***", seed); | ||
| RANDOM = new Random(); |
Contributor
There was a problem hiding this comment.
This should be RANDOM = new Random(seed);.
Contributor
Author
There was a problem hiding this comment.
wow - the whole point of the PR and i didn't even do it right 😞 
fixed now.
Each test suite now uses the same instance of Random which prints the seed given to it so that if there is a failure, we can easily try to recreate it by taking the seed and passing it in as a system property with -DtestSeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1365
Each test suite now uses the same instance of Random which prints the seed given to it so that if there is a failure, we can easily try to recreate it by taking the seed and passing it in as a system property with -DtestSeed. The output logs as:
I didn't replace all of the old use of
Random- there were a couple places where I felt like a trueRandomwas still necessary and just left it alone despite the horror it might cause. Going forward we'll want to use theTestHelper.RANDOMwhenever possible (or, better, just not use aRandomat all).All tests pass with
docker/build.sh -t -n -iVOTE +1