fix(DriverRemoteConnection): return the promise on close#887
Closed
elliotttf wants to merge 1 commit intoapache:masterfrom
Closed
fix(DriverRemoteConnection): return the promise on close#887elliotttf wants to merge 1 commit intoapache:masterfrom
elliotttf wants to merge 1 commit intoapache:masterfrom
Conversation
The jsdoc indicates that the `DriverRemoteConnection.close()` method returns a `Promise`; however, the first time the method is called it returns `undefined`.
Contributor
|
Nice catch! looks good: VOTE: +1 |
Contributor
|
I've filed a ticket to track this bug fix: https://issues.apache.org/jira/browse/TINKERPOP-1995 When creating the ticket, I realized we should we fix this issue in all the active branches... @elliotttf do you mind basing your patch on |
Contributor
Author
|
@jorgebay don't mind at all. Would you like me to keep it open against master, or reopen this against tp32? |
Contributor
|
Thanks! Please reopen this one against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jsdoc indicates that the
DriverRemoteConnection.close()method returns aPromise; however, the first time the method is called it returnsundefined.