Some improvements #998
Closed
Some improvements #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2018 12:39
Since this part of the code is being called very often, it seems more efficient to use a LinkedHashSet instead of an ArrayList, where we get insertion & deletion in O(1) instead of O(n).
When analyzing heap memory consumption we noticed that this particular list had to be enlarged quite often, thus generating unnecessary garbage on the Heap. Quick fix is to init the list with the size that's needed.
nastra
force-pushed
the
some-improvements
branch
from
45435e2 to
a801a36
Compare
Contributor
|
going to close this one since we have #999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally tested with
mvn clean install -DskipIntegrationTests=false -DincludeNeo4j