Fix client ca cert Native Leak when startUp and reload#44
Closed
Chenjp wants to merge 1 commit intoapache:mainfrom
Closed
Fix client ca cert Native Leak when startUp and reload#44Chenjp wants to merge 1 commit intoapache:mainfrom
Chenjp wants to merge 1 commit intoapache:mainfrom
Conversation
Ensure the allocated memory is properly reclaimed. Originally, an X509 certificate object is allocated via d2i_X509 but is never released after being added to the SSL context.
Contributor
|
Thanks. Applied manually so I could add a change log entry, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the allocated client ca cert memory is properly reclaimed, which is dangerous if a tomcat-based multi-tenants gateway service with dynamic SNI feature or tenant cert configuration hot reload feature enabled. The native heap ignore -Xmx settings, is invisible to most standard java monitoring tools until the ENTIRE OS RUNS OOM.
Deterministic native mem leak is realistic, per observation in PoC, via /manager/text/sslReload x 10000 times → 12.6MB
Originally, an X509 certificate object is allocated via d2i_X509 but is never released after being added to the SSL context.