reject out-of-range values in range and content-range parsers#1012
Merged
Conversation
A numeric field larger than Long.MAX_VALUE let a NumberFormatException escape readLong instead of the documented null return, turning a malformed range into a 500 in DefaultServlet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ranges.parseandContentRange.parseare documented to return null for any value they can't accept, but a numeric field larger thanLong.MAX_VALUE(e.g.Range: bytes=0-99999999999999999999) lets aNumberFormatExceptionescapereadLong. InDefaultServletthat turns the usual 416/400 for a bad range into a 500. Catch it where the longs are read and return null, like every other malformed range.