catch invalid base64 in MimeUtility encoded-word decoder#1013
Closed
sahvx655-wq wants to merge 1 commit into
Closed
catch invalid base64 in MimeUtility encoded-word decoder#1013sahvx655-wq wants to merge 1 commit into
sahvx655-wq wants to merge 1 commit into
Conversation
Base64.getDecoder().decode throws IllegalArgumentException rather than IOException, so a malformed RFC 2047 encoded-word in a Content-Disposition filename param escaped decodeWord and ParameterParser.parse as an unchecked exception. Add it to the existing catch so it surfaces as the documented UnsupportedEncodingException.
Contributor
|
This is a package renamed fork of Commons File Upload. Any changes need to be made in that project and then Tomcat will pick up those changes when it is next released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base64.getDecoder().decode throws IllegalArgumentException, not IOException, so a Content-Disposition param like
filename="=?utf-8?B?@@@@?="lets the unchecked exception escapedecodeWordandParameterParser.parsestraight out of multipart parsing, where the only catch handlers are for IOException/IllegalStateException. Adding it to the existing catch keeps the contract that decodeWord throws UnsupportedEncodingException for malformed encodings, which decodeText/ParameterParser already handle by keeping the raw value.