use getEnd() not getLength() when filtering ctls in header writers#1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while reading the response header write path i noticed the control-character filter in Http11OutputBuffer.write and AjpMessage.appendBytes loops up to bc.getLength() rather than the end of the data. for a ByteChunk the valid range is [getStart(), getEnd()) and getLength() is getEnd() minus getStart(), so when the chunk start is non-zero the bytes past getLength() are never stripped, and if start is past length the loop does not run at all. the same byte filtering loops in Http11Processor, StreamProcessor and UEncoder all use getEnd(). this brings these two into line.