Free server certificate (x509cert) after SSL_CTX_use_certificate in O…#977
Merged
markt-asf merged 1 commit intoapache:mainfrom Apr 2, 2026
Merged
Conversation
…penSSLContext SSL_CTX_use_certificate makes an internal copy, so the caller should free the original. This is the same class of bug fixed by commit 8ef5efc for client CA certificates after SSL_CTX_add_client_CA. X509_free is added on: - early return when private key parsing fails (x509cert already allocated) - error path when SSL_CTX_use_certificate fails - success path after SSL_CTX_use_certificate (copy already made internally) Co-authored-by: markt-asf <markt@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…penSSLContext
SSL_CTX_use_certificate makes an internal copy, so the caller should free the original. This is the same class of bug fixed by commit 8ef5efc for client CA certificates after SSL_CTX_add_client_CA.
X509_free is added on: