Fix missing return in WebdavServlet doDelete after precondition failure#982
Merged
rmaucher merged 1 commit intoapache:mainfrom Apr 7, 2026
Merged
Conversation
a2a27c0 to
d8e506f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a WebDAV DELETE request includes a conditional header like
If-Unmodified-SinceorIf-Match, and the condition fails, the server correctly responds with HTTP 412 Precondition Failed. However, it still proceeds to delete the resource becausedoDelete()is missing areturnstatement after setting the 412 status. ThedoPut()method handles this correctly by returning immediately.This means conditional headers are not enforced for DELETE operations. A file can be deleted by any client regardless of the precondition check result.
POC
The fix adds the missing
returnafter setting the 412 status, consistent with howdoPut()already handles this case.