This repository was archived by the owner on Dec 4, 2018. It is now read-only.
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59226 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StandardJarScanner ignores jars in manifest Class-path header
| * {@link java.net.URLClassLoader#getURLs()}. | ||
| * </p> | ||
| * @param cl | ||
| * @return |
Contributor
There was a problem hiding this comment.
This method assumes all JARs have manifests. The assumption is not valid.
Author
|
I commented my response in ASF Bugzilla |
| } | ||
| String[] entries = classPath.split(" "); | ||
| for (String entry : entries) { | ||
| File f = new File(entry); |
Contributor
There was a problem hiding this comment.
Class-Path entries are always relative to the containing JAR.
Author
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardJarScanner ignores jars in manifest Class-path header.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226
http://stackoverflow.com/questions/35922072/scanning-manifest-classpath-jars-in-embeeded-tomcat/36185408#36185408