Add some JavaDoc to the maven plugin #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
reviewed
Dec 12, 2018
| */ | ||
| public abstract class AbstractAddressMojo extends AbstractMojo { | ||
| /** | ||
| * The Tomee http port. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeHttpPort; | ||
|
|
||
| /** | ||
| * The Tomee https port. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeHttpsPort; | ||
|
|
||
| /** | ||
| * The Tomee host. |
radcortez
reviewed
Dec 12, 2018
| protected boolean skipCurrentProject; | ||
|
|
||
| /** | ||
| * The Tomee version. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeVersion; | ||
|
|
||
| /** | ||
| * The Tomee group id. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeGroupId; | ||
|
|
||
| /** | ||
| * The Tomee artifact id. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeClassifier; | ||
|
|
||
| /** | ||
| * The Tomee shutdown port. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeShutdownPort; | ||
|
|
||
| /** | ||
| * The Tomee shutdown attempts. |
radcortez
reviewed
Dec 12, 2018
| protected int tomeeShutdownAttempts; | ||
|
|
||
| /** | ||
| * The Tomee shutdown command. |
radcortez
reviewed
Dec 12, 2018
| protected String tomeeShutdownCommand; | ||
|
|
||
| /** | ||
| * The Tomee ajp port. |
radcortez
reviewed
Dec 12, 2018
| protected boolean useConsole; | ||
|
|
||
| /** | ||
| * The Tomee already installed. |
radcortez
reviewed
Dec 12, 2018
| } | ||
|
|
||
| /** | ||
| * Gets wait tom ee. |
radcortez
reviewed
Dec 12, 2018
| /** | ||
| * Gets wait tom ee. | ||
| * | ||
| * @return the wait tom ee |
Contributor
Author
There was a problem hiding this comment.
My bad! Definitely TomEE!
Contributor
|
Hey @dalexandrov! Great to have you here :) Thank you for your PR. If you could just replace the name TomEE instead of Tomee or other variations it should be good to go :) |
|
What purpose is served by that kind of JavaDocs? I see only unneeded noise that duplicates what types/methods/fields/... already deliver with their names. |
pzygielo
reviewed
Dec 18, 2018
| import java.util.Map; | ||
|
|
||
| /** | ||
| * The type Synchronization to sunc the files and directories. |
pzygielo
reviewed
Dec 18, 2018
| * A customizer (see tomee-maven-plugin) allowing to take current project binaries (target/classes) | ||
| * and merge them in tomee for patch cases. | ||
| * | ||
| * <p> |
pzygielo
reviewed
Dec 18, 2018
| import java.util.Collection; | ||
|
|
||
| /** | ||
| * The type Class loader factory is used to load classes drom the supplied *.jar and *.zip |
cesarhernandezgt
added a commit
to cesarhernandezgt/tomee
that referenced
this pull request
Oct 25, 2023
udate to Tomcat 10.0.28-TT.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some JavaDoc. Some parts are generated, but the most is handwritten.