TOMEE-4631 - arquillian-tomee-remote: re-register container on every Manager bootstrap#2816
Merged
Conversation
…Manager bootstrap RemoteTomEEExtension guarded container registration behind a JVM-static AtomicBoolean latch. Arquillian instantiates the extension and calls register() once per Manager bootstrap, so the latch let only the first Manager in a JVM fork register its DeployableContainer. Any second Manager in the same fork (e.g. maven-failsafe-plugin's rerunFailingTestsCount) got an empty ContainerRegistry and failed every deployment with "DeploymentScenario contains a target (_DEFAULT_) not matching any defined Container in the registry". Drop the static latch (and the static lock that only guarded it) and register unconditionally, matching EmbeddedTomEEExtension. The existing try/catch(IllegalArgumentException) remains as the guard against a genuine double-registration within a single builder. Adds RemoteTomEEExtensionReRegistrationTest covering re-registration across two Manager bootstraps in the same JVM.
jungm
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TOMEE-4631
RemoteTomEEExtensionguarded container registration behind a JVM-static latch, so only the first ArquillianManagerper JVM fork registered itsDeployableContainer. A secondManager(e.g. failsafererunFailingTestsCount) got an empty registry and failed withDeploymentScenario contains a target (_DEFAULT_) not matching any defined Container.Drop the static latch and register unconditionally, like
EmbeddedTomEEExtension. Adds a regression test covering re-registration across twoManagerbootstraps in the same JVM.