-
Notifications
You must be signed in to change notification settings - Fork 692
Example Project - Kotlin, CDI, JAX-RS #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Kotlin - CDI - JAX-RS - Domain-Driven Design - Ports and Adapters - Constructor injection, interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @brandonlamb Thanks for the PR.
Found one issue. You need to add the project module name to the examples pom.xml.
We also need at least one test running with maven, verifying that the setup is working... This is useful to make sure we are not breaking anything as we evolve TomEE. Right now I see:
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ kotlin-cdi-jaxrs ---
[INFO] Tests are skipped.
Please also add a README.adoc explaining the motivation and setup and mention that docker is a pre-requisite to run the build.sh
|
Please register and send us an email to dev@tomee.apache.org. We would love to hear from you over there! |
|
Hi @brandonlamb! I don't know if you had the time to take a look at the previous comments...
|
|
I'm happy to help add headers to the PR or any other things this would need. Very excited about having a Kotlin example -- never tried it myself :) |
|
@brandonlamb let me know if you don't have time to work on it anymore. I'll dig in and see what it would take to finish. |
|
haha yea at the moment I can't make time to get that last 10% over the finish line. I was out on holiday for this so I had time. Figured I would try to come back at some point but didnt want to leave the project and this PR just hanging in limbo |
|
No worries -- I've spent most my life in that spot (wanting to have time for open source, getting nearly there and losing the time). In practice, you take progressively bigger tasks, so this dynamic never changes. (so congratulations, you're a true open source hacker :) ) What needs to happen for this to "finish"? (i'd be excited to dig in) |
DO NOT MERGE YET - WIP
Example includes the following, slightly more than a basic "hello world".
TODO