Skip to content

Conversation

@brandonlamb
Copy link

@brandonlamb brandonlamb commented Dec 29, 2018

DO NOT MERGE YET - WIP

Example includes the following, slightly more than a basic "hello world".

  • Kotlin
  • CDI (DI and events)
  • JAX-RS (including ExceptionMappers for error handling)
  • Domain-Driven Design
  • Ports and Adapters
  • Constructor injection, interfaces
  • Dockerfile to build and run in Docker (multi-stage build)

TODO

  • Add README documenting the example (need to learn asciidoc first)
  • Add tests? Meh. Test in production.

- Kotlin
- CDI
- JAX-RS
- Domain-Driven Design
- Ports and Adapters
- Constructor injection, interfaces
@brandonlamb brandonlamb changed the title Example Project - Kotiln, CDI, JAX-RS Example Project - Kotlin, CDI, JAX-RS Dec 29, 2018
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brandonlamb Thanks for the PR.

Found one issue. You need to add the project module name to the examples pom.xml.
We also need at least one test running with maven, verifying that the setup is working... This is useful to make sure we are not breaking anything as we evolve TomEE. Right now I see:

[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ kotlin-cdi-jaxrs ---
[INFO] Tests are skipped.

Please also add a README.adoc explaining the motivation and setup and mention that docker is a pre-requisite to run the build.sh

@brunobat
Copy link
Contributor

Please register and send us an email to dev@tomee.apache.org. We would love to hear from you over there!

@brunobat
Copy link
Contributor

Hi @brandonlamb! I don't know if you had the time to take a look at the previous comments...
I also found two more issues:

  • You are committing a .gitignore file
  • All the files need an Apache 2.0 license. Even the xml ones.

@dblevins dblevins reopened this Jan 10, 2019
@dblevins
Copy link
Contributor

I'm happy to help add headers to the PR or any other things this would need. Very excited about having a Kotlin example -- never tried it myself :)

@dblevins
Copy link
Contributor

@brandonlamb let me know if you don't have time to work on it anymore. I'll dig in and see what it would take to finish.

@brandonlamb
Copy link
Author

haha yea at the moment I can't make time to get that last 10% over the finish line. I was out on holiday for this so I had time. Figured I would try to come back at some point but didnt want to leave the project and this PR just hanging in limbo

@dblevins
Copy link
Contributor

dblevins commented Jan 10, 2019

No worries -- I've spent most my life in that spot (wanting to have time for open source, getting nearly there and losing the time). In practice, you take progressively bigger tasks, so this dynamic never changes. (so congratulations, you're a true open source hacker :) )

What needs to happen for this to "finish"? (i'd be excited to dig in)

@Humbedooh Humbedooh deleted the branch apache:master August 16, 2022 09:14
@Humbedooh Humbedooh closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants