Some of the returned values are performance dependant - stddev#349
Closed
doychin wants to merge 1 commit intoapache:masterfrom
Closed
Some of the returned values are performance dependant - stddev#349doychin wants to merge 1 commit intoapache:masterfrom
doychin wants to merge 1 commit intoapache:masterfrom
Conversation
…stogram This one is more complex as change. In order to reuse existing expected values and filter the value that is not always the same I've implemented some parsing before comparing the returned string with expected string. In case you don't like it I'm open for suggestions.
Contributor
|
Hi @doychin. |
Contributor
Author
Contributor
|
Ok. If the fix is already in, probably you can close this PR. |
Contributor
Author
|
No. Only the fix for PR #347 is in. The problem with that commit is that it changes 2 files. One that introduces the conflict and that change is not OK. The test will fail again on next run. The other is the same fix I propose in #347. If you can revert that commit then you should be able to apply both PR #347 and this (#349) |
Contributor
|
I've rebased and fix the conflict. Should be ok now. Thank you @doychin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is more complex as change. stdDev value in histogram depends on how fast values are added to the histogram on the server. In order to reuse existing expected values and filter the value that is not always the same, I've had to implement some parsing before comparing the returned string with expected string.
In case you don't like it I'm open for suggestions.