TOMEE-2515 MicroProfile JWT 1.1 Cleanup #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rification" key "IssuedBy" becomes "issuer" to more directly map to the JWT
… isn't a request context object, but app scoped configuration.
Make it clearer that this is equivalent to JWTAuthConfiguration but created via MP-JWT standard properties.
jeanouii
reviewed
May 7, 2019
|
|
||
| private Map<String, Key> signerKeys; | ||
| private String issuedBy; | ||
| private Map<String, Key> publicKeys; |
Contributor
There was a problem hiding this comment.
Not so sure about this one.
Key is the base class and can be a public key or a secret key.
What about signingKey?
It would be valid for either symmetric or asymmetric key.
Contributor
Author
There was a problem hiding this comment.
Changed to "verificationkey" most places
… Favor "verificationKey" over "publicKey" when possible.
Still not wired up to an interceptor
…ional. Needs tests, logging and documentation
Will come back and attempt to fix builder pattern in JsonWebTokenValidator
dblevins
changed the title
Contributor
Author
|
Merging so we can get a build from the CI and move forward with the 8.0.0-M3 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in the trimming code stage. Plan to get on to logging improvements and greater tests shortly.