Rewrite of TOMEE-2517 Bean Validation with MicroProfile JWT#566
Merged
dblevins merged 8 commits intoapache:masterfrom Sep 9, 2019
Merged
Rewrite of TOMEE-2517 Bean Validation with MicroProfile JWT#566dblevins merged 8 commits intoapache:masterfrom
dblevins merged 8 commits intoapache:masterfrom
Conversation
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
TOMEE-2517 Bean Validation with MicroProfile JWT
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall idea of this class is to split a developer's bean class into two parts which are used by the different code that needs to validate.
So if you have a class called
Foothat uses Bean Validation constraints for both JWT and Return value, you will get the following two classes generated:Foo$$ReturnConstraintsused by an updated version ofBValInterceptorFoo$$JwtConstraintsused byValidationInterceptor(which likely needs a more specific name now)To determine if we need to do any of this for a particular class, we have
ClassValidationData. If it looks as there are JWT constraints on the class, we useClassValidationGeneratorto handle the generation, which in turn delegates to these classes to do the ASM work:JwtValidationGeneratorReturnValidationGenerator