TOMEE-2696 Complete mp-config-source-database Example's Explanation#576
Merged
jgallimore merged 2 commits intoapache:masterfrom Oct 15, 2019
Merged
TOMEE-2696 Complete mp-config-source-database Example's Explanation#576jgallimore merged 2 commits intoapache:masterfrom
jgallimore merged 2 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
This looks great! Nice job! I found one very minor error. Change "need to beging" to "need to begin" removing the 'g' at the end of begin. Other than that its ready to go! |
Contributor
Author
|
addressed @monsonhaefel review at commit 173d757 |
|
Perfect. Let's get this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.