Ddded missing dependency for microprofile#608
Closed
scriptmonkey wants to merge 1 commit into
Closed
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
rmannibucau
reviewed
Nov 13, 2019
| </exclusions> | ||
| </dependency> | ||
|
|
||
| <dependency> <!-- Added in for backwards compatibility with the move to Jakarta EE coordinates --> |
Contributor
There was a problem hiding this comment.
looks like you just want to copy the same than in openejb-core for consistency + use provided scope since on j8 it must not be transitive
see https://github.com/apache/tomee/blob/master/container/openejb-core/pom.xml#L558
Contributor
Author
|
I will fix and make a new pull request. |
Contributor
|
You could just make the change in your branch, commit and push again (which will update the PR here). Alternatively we could merge this, and you follow up with the refactor - that's also fine. New PR is also good. Shout if you get stuck, and thanks for giving this a go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira card: TOMEE-2731
This fixes a missing dependency for microprofile. This was discussed in the dev email list.
I added: