Skip to content

Ddded missing dependency for microprofile#608

Closed
scriptmonkey wants to merge 1 commit into
apache:masterfrom
scriptmonkey:master
Closed

Ddded missing dependency for microprofile#608
scriptmonkey wants to merge 1 commit into
apache:masterfrom
scriptmonkey:master

Conversation

@scriptmonkey
Copy link
Copy Markdown
Contributor

Jira card: TOMEE-2731

This fixes a missing dependency for microprofile. This was discussed in the dev email list.

I added:

<dependency> <!-- Added in for backwards compatibility with the move to Jakarta EE coordinates -->
        <groupId>com.sun.activation</groupId>                                      
        <artifactId>jakarta.activation</artifactId>                                
        <version>1.2.1</version>                                                   
</dependency> 

@asf-ci
Copy link
Copy Markdown

asf-ci commented Nov 13, 2019

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link
Copy Markdown

asf-ci commented Nov 13, 2019

Can one of the admins verify this patch?

@asf-ci
Copy link
Copy Markdown

asf-ci commented Nov 13, 2019

Can one of the admins verify this patch?

</exclusions>
</dependency>

<dependency> <!-- Added in for backwards compatibility with the move to Jakarta EE coordinates -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you just want to copy the same than in openejb-core for consistency + use provided scope since on j8 it must not be transitive

see https://github.com/apache/tomee/blob/master/container/openejb-core/pom.xml#L558

@scriptmonkey
Copy link
Copy Markdown
Contributor Author

I will fix and make a new pull request.

@jgallimore
Copy link
Copy Markdown
Contributor

You could just make the change in your branch, commit and push again (which will update the PR here). Alternatively we could merge this, and you follow up with the refactor - that's also fine. New PR is also good. Shout if you get stuck, and thanks for giving this a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants