TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl#613
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
rmonson
left a comment
rmonson
left a comment
There was a problem hiding this comment.
The acl.Group has been deprecated since Java 9 and was removed in Java 14 but I have two questions. According to documentation it was replace by Policy not Principle. So is your code still correct? Also, are we even supporting Java 14? Getting a head of the depreciation is great, but does this change break compatibility with Java 8?
|
Hi, In the code acl.Group is used basically as a Principal with members support, is not used as a Policy, as far as I can see. With this change our environment works in jdk11, 12, 13 and 14, I don't see any reason why it wouldn't work in jdk8 (but of course I don't know all the use cases here). |
|
I'll merge this in, and we'll let the CI build it. Hopefully all will look good, but we'll revisit it if we see tests failing. |
5 participants
Some tests in openejb-core fail, but it doen't seem related at all