Skip to content

TOMEE-2767 / Deleting typos and correcting heading syntax#628

Merged
cesarhernandezgt merged 2 commits into
apache:masterfrom
bitcod3r:TOMEE-2767-fix-erroneous-characters-in-documentation
Jan 31, 2020
Merged

TOMEE-2767 / Deleting typos and correcting heading syntax#628
cesarhernandezgt merged 2 commits into
apache:masterfrom
bitcod3r:TOMEE-2767-fix-erroneous-characters-in-documentation

Conversation

@bitcod3r
Copy link
Copy Markdown
Contributor

@bitcod3r bitcod3r commented Jan 30, 2020

I confirm that:

  • Code compiles with JDK 8.
  • adoc file produces a correct output with asciidoc.
  • And, all tests pass successfully.

This is my first PR to the TomEE project. Please, give me your feedback to know what might I improve.

More PRs are coming... :)

@djencks
Copy link
Copy Markdown
Contributor

djencks commented Jan 30, 2020

I think this is a fantastic change, thanks!

Personally, I think the page would look even better with the links in unordered lists rather than paragraphs with line breaks. Does anyone agree?

@bitcod3r
Copy link
Copy Markdown
Contributor Author

Personally, I think the page would look even better with the links in unordered lists rather than paragraphs with line breaks. Does anyone agree?

+1 @djencks, I agree with you. It is semantically correct to markup those links as (unordered) lists of resources. Adding 1 commit to the current PR.

Copy link
Copy Markdown
Contributor

@cesarhernandezgt cesarhernandezgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks much @bitcod3r bitcod3r and also thank you @djencks for the review!

@cesarhernandezgt cesarhernandezgt merged commit f80a55a into apache:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants