TOMEE-2976 - Provide two examples using Arquillian & JUnit 5#765
Merged
rzo1 merged 5 commits intoapache:masterfrom Mar 25, 2021
rzo1:TOMEE-2976_
Merged
TOMEE-2976 - Provide two examples using Arquillian & JUnit 5#765rzo1 merged 5 commits intoapache:masterfrom rzo1:TOMEE-2976_
rzo1 merged 5 commits intoapache:masterfrom
rzo1:TOMEE-2976_
Conversation
Contributor
cesarhernandezgt
left a comment
cesarhernandezgt
left a comment
There was a problem hiding this comment.
Thank you much @rzo1 for the PR.
I ran locally the PR and worked fine. I just have a couple of comments thinking on previous issues we have had when running the full build test in a shared CI environment.
examples/junit5-arquillian-simple-websockets/src/test/java/resources/arquillian.xml
Outdated
Show resolved
Hide resolved
...rquillian-simple-websockets/src/test/java/org/superbiz/websockets/WebSocketResourceTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # examples/pom.xml
Contributor
Author
|
@cesarhernandezgt The failing tests in https://ci-builds.apache.org/job/Tomee/job/pull-request/132/ seem unrelated to me. Is this a Jenkins issue? wdyt? |
…tes JUnit 5 in both examples to 5.8.0-M1 and arquillian to 1.7.0.Alpha9 (> Alpha5 required for JUnit 5)
Contributor
Author
|
Ok. It seems, that the PR builder is now green again. I will merge this two JUnit 5 related examples. If we need to adjust anything afterwards, I will happily doing it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this MR do?
References