Allow files to be excluded on upload

[sbp]

As requested on Slack.

[dave2wave]

We need to use a simple method. I'm not sure why they had this issue as their packages should not be in the main directory of their repository.

[dave2wave]

I think a .atr-ignore file with gitignore syntax in their directory is the best way.

[erisu]

packages should not be in the main directory of their repository.

The packages were not in the main directory of the repository.

I created and committed an empty release-staging directory within the repo and added a .gitkeep file so I could commit an empty directory.

If a directory didn't exist before executing npm pack for the convenience package or git archive for the source packages, the command would have failed (for writing: No such file or directory).

Maybe I was overthinking the structure.

I wrote it this way specifically so both reviewers and I could test each GHA workflow step locally and reproduce each tarball and checksum to compare with what was published to the ATR. The directory was also added to .gitignore so git status/git diff wouldn't complain about new untracked files.

I was probably trying to avoid a setup step (mkdir) in actions so that the release and review documentation remained as simple as executing git archive, npm pack, and sha512sum.

There might be an optional solution I could implement on my end, if we want to try and avoid adding more logic to ATR. For example, I could delete the .gitkeep, in a step on GHA workflow, file before running upload-to-atr step.

[dave2wave]

Perhaps, we should skip all .* files on upload. (unless we want to upload "rat excludes".

[sbp]

I think in this case removing .gitkeep before upload is the right thing to do. It's a common workaround for a problem with Git, but it specifically indicates an empty directory, so I agree that once files are generated in the directory it should be removed even if those files aren't going to be committed.

But I wonder, @erisu, why you can't create the directory in the workflow, and why, when testing locally, you can't create the directory at the start of the build process?

[sbp]

Actually I suppose .gitkeep indicates a directory that is empty according to Git, so if the files aren't going to be committed (and indeed are in .gitignore) then the .gitkeep file shouldn't be removed. I think we should probably add an ignore for just that file. We may have to add others anyway.