TRAFODION-2847 optimize dcs log format

[gpj1987]

previous logs look like

2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node Number: , CPU: , PIN: , Process Name: , , ,Dcs 2.3.0
2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node Number: , CPU: , PIN: , Process Name: , , ,Revision 1efa9db
2017-12-14 05:31:11,417, INFO, org.trafodion.dcs.util.VersionInfo, Node Number: , CPU: , PIN: , Process Name: , , ,Compiled by traf on Thu Dec 14 05:30:52 UTC 2017
2017-12-14 05:31:12,544, INFO, org.trafodion.dcs.master.DcsMaster, Node Number: , CPU: , PIN: , Process Name: , , ,Connected to ZooKeeper

now logs look like

2017-12-14 10:57:08,949, [Thread-2], INFO, org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107) | Dcs 2.3.0
2017-12-14 10:57:08,952, [Thread-2], INFO, org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107) | Revision 1efa9db
2017-12-14 10:57:08,953, [Thread-2], INFO, org.trafodion.dcs.util.VersionInfo.logVersion(VersionInfo.java:107) | Compiled by traf on Thu Dec 14 09:46:05 UTC 2017
2017-12-14 10:57:10,071, [Thread-2], INFO, org.trafodion.dcs.master.DcsMaster.run(DcsMaster.java:141) | Connected to ZooKeeper

[Traf-Jenkins]

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2261/

[Traf-Jenkins]

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2261/

[venkat1m]

This change will break the LOGS TMUDF feature which can be used to fetch and aggregate Trafodion log entries across all nodes via SQL. We need the Node Number, PIN and Process Name. When looking at a consolidated view we want to identify the node and process name that emitted the log event.

Try this SQL query to see the expected columns and make sure it can pick up the DCS log entries and the log message is parsed correctly.

select *from udf(event_log_reader()) limit 1;

[DaveBirdsall]

@venkat1m, could you point to the source code for the UDF event_log_reader so that @gpj1987 can change that as well?

[Traf-Jenkins]

Can one of the admins verify this patch?

[Traf-Jenkins]

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2284/

[Traf-Jenkins]

Can one of the admins verify this patch?

[venkat1m]

@DaveBirdsall The LOG reader UDF is trafodion/core/sql/sqludr/SqlUdrPredefLogReader.cpp .
But I think the fix should be in the log file format, not the UDF reader. The missing entries need to be added to the log file by the publisher at event generation time. The UDF is just the consumer.

[Traf-Jenkins]

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2284/

[gpj1987]

I am a little confused about this , although select *from udf(event_log_reader()) limit 1; seems not have problem , so close it first.