This repository was archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2908] create table with wrong char length hang and crash #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2417/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2417/ |
DaveBirdsall
reviewed
Feb 5, 2018
core/sql/bin/SqlciErrors.txt
Outdated
| 1139 ZZZZZ 99999 BEGINNER MAJOR DBADMIN System-generated column $0~ColumnName of base table $1~TableName cannot appear in the search condition of a check constraint definition. | ||
| 1140 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Row-length $0~int0 exceeds the maximum allowed row-length of $1~int1 for table $2~TableName. | ||
| 1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN --- unused --- | ||
| 1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Key-length $0~int0 exceeds the maximum allowed rowkey length $1~int1. |
Contributor
There was a problem hiding this comment.
Consider rewording: "Key length $0-int0 exceeds the maximum allowed key length of $1~int1".
Contributor
There was a problem hiding this comment.
Also, would you please add the new message to the Messages Guide? Thanks.
Contributor
Author
There was a problem hiding this comment.
Thanks Dave for the review, I will update teh Message Guide and modify the workding
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2422/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2422/ |
DaveBirdsall
approved these changes
Feb 6, 2018
Contributor
DaveBirdsall
left a comment
DaveBirdsall
left a comment
There was a problem hiding this comment.
+1 Looks good to me.
Contributor
Author
|
Thanks Dave for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a check if the key length is too long report error. Otherwise, SQL will go into a very long process to build the encoded key and finally failed. And in some cases crash, it makes little sense to check why it crash, so just add check and return error when key is too long.
HBase max rowkey len is 32K, so it is the hard limit for now.