-
Notifications
You must be signed in to change notification settings - Fork 150
[TRAFODION-3007] update statistics report error on volatile table #1492
Conversation
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2509/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2509/ |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2514/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2514/ |
DaveBirdsall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Looks good. One thing to check in your unit testing: Please be sure that any SB_HISTOGRAM* table in the volatile schema gets dropped when the schema gets dropped.
core/sql/ustat/hs_parser.cpp
Outdated
| HSHandleError(retcode); // causes a return from this function | ||
|
|
||
| // The code below is old code that will be needed once we turn on | ||
| // support for UPDATE STATISTICS on volatile tables. We leave it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could delete the comments "The code below is old code..." since we are turning support back on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dave. SB_HISTOGRAM* table in the volatile schema gets dropped when the schema gets dropped. I had tested that.
…emove useless comments
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2516/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2516/ |
No description provided.