Skip to content
This repository was archived by the owner on Jun 7, 2021. It is now read-only.

Conversation

@andyyangcn
Copy link
Contributor

No description provided.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2509/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2514/

@Traf-Jenkins
Copy link

Copy link
Contributor

@DaveBirdsall DaveBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good. One thing to check in your unit testing: Please be sure that any SB_HISTOGRAM* table in the volatile schema gets dropped when the schema gets dropped.

HSHandleError(retcode); // causes a return from this function

// The code below is old code that will be needed once we turn on
// support for UPDATE STATISTICS on volatile tables. We leave it here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could delete the comments "The code below is old code..." since we are turning support back on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave. SB_HISTOGRAM* table in the volatile schema gets dropped when the schema gets dropped. I had tested that.

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2516/

@Traf-Jenkins
Copy link

@asfgit asfgit merged commit 8913b31 into apache:master Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants