This repository was archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-1881] A better way to solve TRAFODION-1858 #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2938/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2938/ |
DaveBirdsall
approved these changes
Aug 15, 2018
Contributor
DaveBirdsall
left a comment
DaveBirdsall
left a comment
There was a problem hiding this comment.
+1 Looks good to me. Nice change!
Contributor
Author
|
thank you Dave for the review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous fix to TRAFODION-1858, I add a new method to check if a column is a system column by comparing the column name with "SALT", "DIVISION" etc, that is not a good way.
This is a new implementation, it use more robust way to tell if a column is a system column.
To check the RI, the predicate only need to check the user specified Primary Column.