This repository was archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-3282] Fix buffer overrun in ExHdfsScanTcb::work #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3153/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/3153/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this pull request:
Fix a buffer overrun in ExHdfsScanTcb::work, which happens when we process a Hive row longer than we expect and that row spans read buffers. Now we will raise an 8457 error in this case.
A workaround to avoid error 8457 is to use CQD HIVE_MAX_STRING_LENGTH_IN_BYTES 'nnnn', setting nnnn to the length of the longest string in the Hive table. There was a bug in UPDATE STATISTICS ... CREATE SAMPLE where this particular CQD was not passed down to the appropriate tdm_arkcmp, defeating the workaround. This bug has been fixed.