Optimize time and value in filter by TsFile statistics.#172
Merged
JackieTien97 merged 9 commits intoapache:developfrom Jul 18, 2024
Merged
Optimize time and value in filter by TsFile statistics.#172JackieTien97 merged 9 commits intoapache:developfrom
JackieTien97 merged 9 commits intoapache:developfrom
Conversation
JackieTien97
requested changes
Jul 10, 2024
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
Add UT For all you changed filters.
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java
Outdated
Show resolved
Hide resolved
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java
Outdated
Show resolved
Hide resolved
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java
Outdated
Show resolved
Hide resolved
| if (valuesMin == valuesMax) { | ||
| for (T val : candidates) { | ||
| if (valuesMin != val) { | ||
| return false; |
Contributor
There was a problem hiding this comment.
wrong?
Any values in set equals to valuesMin, should return true
|
|
||
| @Override | ||
| protected boolean canSkip(Statistics<? extends Serializable> statistics) { | ||
| throw new NotImplementedException(); |
Contributor
There was a problem hiding this comment.
return false? why throw exception here?
Contributor
Author
There was a problem hiding this comment.
Would IoTDB push down NOT IN operator for now?
Contributor
Author
There was a problem hiding this comment.
Anyway, return false won't be wrong. Fixed.
|
|
||
| @Override | ||
| protected boolean allSatisfy(Statistics<? extends Serializable> statistics) { | ||
| throw new NotImplementedException(); |
Contributor
There was a problem hiding this comment.
return false? why throw exception here?
Contributor
Author
|
PTAL~ |
JackieTien97
requested changes
Jul 12, 2024
| T valuesMin = (T) statistics.get().getMinValue(); | ||
| T valuesMax = (T) statistics.get().getMaxValue(); | ||
| // All values are same | ||
| if (valuesMin == valuesMax) { |
Contributor
There was a problem hiding this comment.
valuesMin.compareTo(valuesMax) == 0?
JackieTien97
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.