Fix the problem that ChunkMeta of empty Chunk is not processed #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jt2594838
approved these changes
Nov 6, 2024
Contributor
jt2594838
left a comment
jt2594838
left a comment
There was a problem hiding this comment.
LGTM, but I am not sure if it should be skipped or a place holder is needed.
shuwenwei
reviewed
Nov 6, 2024
java/tsfile/src/main/java/org/apache/tsfile/read/reader/series/FileSeriesReader.java
Show resolved
Hide resolved
jt2594838
approved these changes
Nov 6, 2024
jt2594838
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Fix the problem that ChunkMeta of empty Chunk is not processed * add TsFileReaderEmptyChunkTest * fix * add licensed * modify code format
jt2594838
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Fix the problem that ChunkMeta of empty Chunk is not processed * add TsFileReaderEmptyChunkTest * fix * add licensed * modify code format (cherry picked from commit 975210c)
jt2594838
pushed a commit
that referenced
this pull request
Nov 11, 2024
jt2594838
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Fix the problem that ChunkMeta of empty Chunk is not processed * add TsFileReaderEmptyChunkTest * fix * add licensed * modify code format (cherry picked from commit 8310640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title said