Correct the retained size calculation for BinaryColumn and BinaryColumnBuilder#374
Merged
Correct the retained size calculation for BinaryColumn and BinaryColumnBuilder#374
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #374 +/- ##
===========================================
- Coverage 64.71% 64.71% -0.01%
===========================================
Files 541 541
Lines 32310 32309 -1
Branches 4312 4311 -1
===========================================
- Hits 20911 20910 -1
Misses 10902 10902
Partials 497 497 ☔ View full report in Codecov by Sentry. |
Beyyes
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do the performance test, build 1 billion binary using TsBlockBuilder, we only see 1-second performance impact(macOS M2 pro, OpenJDK-21).
Before:
6779
6420
6394
6387
6527
After:
7589
7524
8063
7592
7696
You can replay that test, using the following codes