Open
Conversation
…eader handling of null-only value pages so that Debug builds pass.
jt2594838
reviewed
Mar 4, 2026
In non-strict mode, disable per-write auto page sealing and seal value pages at time-page boundaries to reduce overhead while preserving aligned page semantics.
hongzhi-gao
force-pushed
the
fix/aligned_tv_page_seal
branch
from
d64ab9a to
660f041
Compare
…age_seal # Conflicts: # cpp/src/reader/qds_without_timegenerator.cc
Contributor
Author
|
Force-pushed to clean up an incorrect commit in the previous version. @hongzhi-gao hongzhi-gao force-pushed the fix/aligned_tv_page_seal branch from d64ab9a to 660f041 |
jt2594838
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement aligned-model synchronized page sealing (matching Java semantics) and fix null-handling bugs in both writer and reader paths.
Changes
tsfile_writer.cc).ValuePageData::init; fixend_encode_chunkto correctly handle pre-sealed pages and avoid writing redundant all-null pages in the table model (value_page_writer.cc,value_chunk_writer.cc,time_chunk_writer.cc).get_point_numer() > 0instead ofhas_current_page_data()in the table write loop to prevent excessive sealing of all-null pages, which caused heap corruption (0xC0000374) inTestNullInTable4.read()inQDSWithoutTimeGenerator::next()to avoid reading past the value buffer for null rows.Testing
AlignedSealSync_PointCountWithNulls,AlignedSealSync_TimeMemoryFirst,AlignedSealSync_ValueMemoryFirst.TsFile_Testpasses in both Release and Debug.