Conversation
- Wrap test_lower_case_name and test_tsfile_config in try/finally blocks to ensure generated .tsfile files are cleaned up - Fix test_tree_all_datatype_query_to_dataframe_variants to clean up the correct file (record_write_and_read.tsfile instead of tablet_write_and_read.tsfile) - Add python/tsfile/dataset/__pycache__ to .gitignore Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #787 +/- ##
========================================
Coverage 62.75% 62.75%
========================================
Files 706 706
Lines 42836 42836
Branches 6324 6324
========================================
+ Hits 26881 26882 +1
Misses 14963 14963
+ Partials 992 991 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_lower_case_nameandtest_tsfile_configintry/finallyblocks to ensure generated.tsfilefiles are cleaned up after teststest_tree_all_datatype_query_to_dataframe_variantscleanup bug: was deletingtablet_write_and_read.tsfileinstead ofrecord_write_and_read.tsfilepython/tsfile/dataset/__pycache__to.gitignoreTest plan
try/finallycleanup.tsfilefiles remain after running tests