Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Oct 13, 2025

This PR add patch to update torch to include cuda stream protocol for older version.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues with older PyTorch versions by implementing a patch that ensures the __cuda_stream__ protocol is available for torch.cuda.Stream objects. This change is crucial for maintaining consistent behavior and preventing errors when interacting with CUDA streams in environments where older PyTorch installations might lack this specific protocol, thereby improving the robustness of the TVM FFI with PyTorch.

Highlights

  • PyTorch Compatibility: Introduced a patch to ensure compatibility with older versions of PyTorch regarding CUDA stream handling.
  • CUDA Stream Protocol: Dynamically adds the __cuda_stream__ protocol to torch.cuda.Stream objects if it's not already present, allowing for consistent stream interaction.
  • Conditional Patching: The patch is applied conditionally, only if torch.cuda is available and the __cuda_stream__ attribute is missing from torch.cuda.Stream.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a patch to support the CUDA stream protocol for older versions of PyTorch. The overall approach of monkey-patching torch.cuda.Stream is correct, but the implementation of the patched method __torch_cuda_stream__ has a critical bug. It hardcodes the device ID to 0, which will cause issues in multi-GPU environments. I've provided a suggestion to fix this.

This PR add patch to update torch to include cuda stream
protocol for older version.
@MasterJH5574 MasterJH5574 merged commit 80bd4d8 into apache:main Oct 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants