[CYTHON][REFACTOR] __tvm_ffi_object__ protocol

[tqchen]

This PR does two things:

• We renamed PyNativeObject.__tvm_ffi_object__ to _tvm_ffi_cached_object This is because the dunder convention is normally used for functions instead of attributes
• We then updated the original __tvm_ffi_tensor__ protocol to __tvm_ffi_object__ so that the same protocol can be used for generic objects.

Given the original attribute is hidden to user and we did not yet introduce __tvm_ffi_tensor__ in a formal release, the change should have low impact. We will however freeze the protocol for formal release ideally soon.

[gemini-code-assist]

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the internal object caching mechanism and generalizes the FFI protocol within the tvm_ffi Python package. By renaming an internal attribute and broadening the scope of a key protocol, the changes aim to improve adherence to Python conventions and enhance flexibility for future object types. Given that the affected attribute is internal and the protocol is not yet formally released, the impact of these changes is expected to be minimal.

Highlights

• Internal Attribute Renaming: The internal attribute PyNativeObject.__tvm_ffi_object__ has been renamed to _tvm_ffi_cached_object to align with Python's convention that dunder (double underscore) names are typically reserved for functions rather than attributes.
• Protocol Generalization: The __tvm_ffi_tensor__ protocol has been updated and generalized to __tvm_ffi_object__, allowing it to be used for a broader range of generic objects beyond just tensors.
• Version Update: The project version has been incremented from 0.1.0b17 to 0.1.0b18 in pyproject.toml and python/tvm_ffi/__init__.py.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the FFI object protocol by renaming PyNativeObject.__tvm_ffi_object__ to _tvm_ffi_cached_object and generalizing the __tvm_ffi_tensor__ protocol to __tvm_ffi_object__. The changes are mostly consistent and well-applied across the codebase. I've found a potential issue where a type index is hardcoded, which contradicts the goal of generalizing the protocol. I've also noted a minor docstring error. Overall, a good refactoring effort.