feat: add __bool__ support for Array and Map #380
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in the boolean evaluation of custom Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements __bool__ for Array and Map containers to align their behavior with standard Python collections, along with adding appropriate tests. My review identifies a potential robustness issue: the new methods could cause a crash when used on objects that failed initialization and have a null C handle. I've provided suggestions to add safety checks to prevent null pointer dereferences, making the implementation more robust.
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Very cool addition! Just some minor nits
python/tvm_ffi/container.py
Outdated
|
|
||
| def __bool__(self) -> bool: | ||
| """Return True if the array is non-empty.""" | ||
| return self.__chandle__() != 0 and len(self) > 0 |
There was a problem hiding this comment.
I don't think there's a need to check __chandle__()
| return self.__chandle__() != 0 and len(self) > 0 | |
| return len(self) > 0 |
There was a problem hiding this comment.
Sure, I've removed it. Thanks!
python/tvm_ffi/container.py
Outdated
|
|
||
| def __bool__(self) -> bool: | ||
| """Return True if the map is non-empty.""" | ||
| return self.__chandle__() != 0 and len(self) > 0 |
guan404ming
force-pushed
the
feat/container-bool-support
branch
from
05d2114 to
e31414d
Compare
|
Thanks! |
2 participants
Why
Python's built-in list and dict return False when empty. However, Array and Map containers always returned True because they didn't implement bool, making bool(Array([])) and bool(Map({})) return True unexpectedly.
How