Skip to content

fix(build): Broken Wheel Testing#444

Merged
tqchen merged 1 commit intoapache:mainfrom
junrushao:2026-02-11/fix-mainline-test
Feb 12, 2026
Merged

fix(build): Broken Wheel Testing#444
tqchen merged 1 commit intoapache:mainfrom
junrushao:2026-02-11/fix-mainline-test

Conversation

@junrushao
Copy link
Member

Wheel testing has been broken by #441, which moves test from optional-dependency to dependency-group. This PR fixes this bug.

Wheel testing has been broken by apache#441,
which moves `test` from optional-dependency to dependency-group. This PR
fixes this bug.
@junrushao junrushao marked this pull request as ready for review February 12, 2026 01:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that was preventing wheel testing from functioning correctly. The issue arose from a recent change in how dependencies are managed, specifically the transition from optional-dependency to dependency-group. By updating the cibuildwheel configuration, this PR ensures that the testing process for wheels is restored and operates as expected.

Highlights

  • Wheel Testing Fix: Corrected the cibuildwheel configuration in pyproject.toml by changing test-extras to test-groups to align with recent dependency management updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pyproject.toml
    • Updated cibuildwheel configuration to use test-groups instead of test-extras for test dependency management.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the wheel testing process caused by a recent change in how test dependencies are defined. The fix involves updating the cibuildwheel configuration in pyproject.toml to use test-groups instead of test-extras. This change correctly reflects that 'test' is now a dependency group, not an optional dependency. The fix is accurate and resolves the described issue.

@tqchen tqchen merged commit 89cb606 into apache:main Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants