Conversation
Wheel testing has been broken by apache#441, which moves `test` from optional-dependency to dependency-group. This PR fixes this bug.
Summary of ChangesHello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug that was preventing wheel testing from functioning correctly. The issue arose from a recent change in how dependencies are managed, specifically the transition from optional-dependency to dependency-group. By updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the wheel testing process caused by a recent change in how test dependencies are defined. The fix involves updating the cibuildwheel configuration in pyproject.toml to use test-groups instead of test-extras. This change correctly reflects that 'test' is now a dependency group, not an optional dependency. The fix is accurate and resolves the described issue.
Wheel testing has been broken by #441, which moves
testfrom optional-dependency to dependency-group. This PR fixes this bug.