Skip to content

[TEST] Addback missing test for init once#452

Merged
junrushao merged 1 commit intoapache:mainfrom
tqchen:init-test
Feb 16, 2026
Merged

[TEST] Addback missing test for init once#452
junrushao merged 1 commit intoapache:mainfrom
tqchen:init-test

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 16, 2026

This PR add back missing cpptest for init once.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reintroduces a previously missing C++ test for the init once functionality within the TVM FFI C API. The added tests thoroughly validate the behavior and thread-safety of the TVMFFIHandleInitOnce and TVMFFIHandleDeinitOnce functions under various conditions, ensuring their robustness and correctness.

Highlights

  • New Test File Added: A new C++ test file, test_init_once.cc, has been added to cover the TVMFFIHandleInitOnce and TVMFFIHandleDeinitOnce functions.
  • Comprehensive InitOnce and DeinitOnce Testing: The new test suite includes various scenarios for TVMFFIHandleInitOnce and TVMFFIHandleDeinitOnce, such as successful initialization/deinitialization, idempotent behavior for multiple calls, error handling during init/deinit, and the full init-deinit lifecycle.
  • Multithreaded Safety Verification: Multithreaded tests have been implemented to ensure that TVMFFIHandleInitOnce and TVMFFIHandleDeinitOnce functions are thread-safe, verifying that initialization and deinitialization occur exactly once even when called concurrently by multiple threads.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/cpp/test_init_once.cc
    • Added a new C++ test file for TVMFFIHandleInitOnce and TVMFFIHandleDeinitOnce.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds back a dedicated test file for the init_once functionality, which is a good move for modularity. The tests are comprehensive, covering single-threaded and multi-threaded scenarios, including success, idempotency, and error cases. My feedback focuses on improving code quality by adhering to modern C++ best practices. Specifically, I've suggested replacing C-style casts with static_cast for better type safety and clarity, and pre-allocating memory for vectors in the multi-threaded tests to improve performance and avoid potential reallocations.

This PR add back missing cpptest for init once.
@junrushao junrushao merged commit 4f91e9c into apache:main Feb 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments