Skip to content

[FIX] Fix the config loading in windows case#490

Merged
junrushao merged 1 commit intoapache:mainfrom
tqchen:main
Mar 1, 2026
Merged

[FIX] Fix the config loading in windows case#490
junrushao merged 1 commit intoapache:mainfrom
tqchen:main

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Mar 1, 2026

This PR fixes the config loading in windows case, sometimes in wheel settings the testcase may still need to load core.pyd, so we by default load the library in config mode when it is windows.

This PR fixes the config loading in windows case, sometimes
in wheel settings the testcase may still need to load core.pyd,
so we by default load the library in config mode when it is windows.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with configuration loading on Windows systems. It introduces specific logic to load the core TVM library by default when running on Windows, even in configuration CLI mode. This change is crucial for ensuring that test cases and other components that depend on dynamic link libraries (DLLs) or Cython extensions can correctly locate and utilize them, preventing potential runtime errors.

Highlights

  • Windows Configuration Loading Fix: Implemented a conditional library loading mechanism specifically for Windows platforms (sys.platform.startswith("win32")) to ensure the correct DLL search path is established. This addresses issues where test cases might still require core extensions even when in config CLI mode.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/tvm_ffi/init.py
    • Added Windows-specific logic to load the FFI library (apache-tvm-ffi) using libinfo.load_lib_ctypes when sys.platform indicates a Windows environment.
    • Included a comment explaining the rationale for this change: to set the DLL search path correctly for test cases that might load Cython extensions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with configuration loading on Windows by ensuring the FFI library is loaded even in config mode. The change correctly addresses the problem, but it introduces some code duplication. My review includes a suggestion to refactor the conditional logic to improve maintainability by removing this duplication.

@junrushao junrushao merged commit bad3896 into apache:main Mar 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants