fix(container): align sequence equality and contains#560
Merged
junrushao merged 1 commit intoapache:mainfrom Apr 21, 2026
Merged
fix(container): align sequence equality and contains#560junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances FFI containers, specifically Array and List, by enabling structural equality and containment checks against standard Python sequences like lists and tuples. It introduces helper functions _sequence_compare_other and _sequence_contains to facilitate these comparisons. The review feedback suggests improving the robustness of _sequence_compare_other by handling potential conversion errors, optimizing _sequence_contains to prevent redundant allocations when searching for nested sequences, and reducing code duplication in __ne__ methods by delegating to __eq__.
junrushao
force-pushed
the
split/container-semantics
branch
from
3f3a1aa to
3730d25
Compare
yongwww
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.