pynq: Update pynq driver control logic#21
Closed
dsteger wants to merge 1 commit intoapache:mainfrom
dsteger:ds.pynq_driver
Closed
pynq: Update pynq driver control logic#21dsteger wants to merge 1 commit intoapache:mainfrom dsteger:ds.pynq_driver
dsteger wants to merge 1 commit intoapache:mainfrom
dsteger:ds.pynq_driver
Conversation
An update is needed in the pynq driver to control VTA. Once VTA is started it is necessary to wait for fetch ap_done signal prior to reading compute done flag. Also, the autorestart IPs need to be disabled when complete as well. This logic change will enable a more performant execution by removing the sleep logic.
jinhongyii
pushed a commit
that referenced
this pull request
Sep 5, 2023
This PR makes the chat.cc mostly static allocate memory to reduce overall memory allocations in runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update is needed in the pynq driver to control
VTA. Once VTA is started it is necessary to wait
for fetch ap_done signal prior to reading compute
done flag. Also, the autorestart IPs need to be
disabled when complete as well as good practice.
This logic change will enable a more performant
execution by removing the sleep logic.