-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype:ciRelates to TVM CI infrastructureRelates to TVM CI infrastructure
Description
Concurrent Jenkinsfile changes that happen in a sequence like:
- PR 1 makes changes
- PR 2 makes changes
- PR 1 merges
- PR 2 merges
Can create a situation where both PRs pass CI but break main when merged with failures like https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4024/pipeline.
There is a timestamp in the Jenkinsfile that makes it so these PRs will have a merge conflict (in the example above PR 2 must be rebased and run through CI again before it can merge), we should check that any changes to the Jenkinsfile also change this timestamp (so if say PR 2 did not change the timestamp it wouldn't pass PR CI)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype:ciRelates to TVM CI infrastructureRelates to TVM CI infrastructure